https://bugzilla.redhat.com/show_bug.cgi?id=839653 --- Comment #15 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #14) > It took me a while to notice I missed the %build section in sample from > guidelines. Is it good enough, now? Good. Thank you. > Wrt noticing upstream - I'll investigate if it's worth to send that patch. Thank you. > Spec URL: http://v3.sk/~hexo/rpm/rubygem-slim.spec > SRPM URL: http://v3.sk/~hexo/rpm/rubygem-slim-1.2.2-7.fc17.src.rpm > Description: Slim is a template language whose goal is reduce the syntax to > the essential parts without becoming cryptic. > Fedora Account System Username: mzatko Just to minor non-blcoking nits: * The %check section should be traditionally placed after %install section * Please exclude the %{gem_cache}, i.e. prefix it with %exclude macro -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review