[Bug 866982] Review Request: rubygem-gem-patch - RubyGems plugin for patching gems.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=866982

--- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
First of all, it seems you created the .spec file by hand. While that is
perfectly fine, gem2rpm could save you some work.

* Source URL
  - You did not provided full source URL. Your URL should be:

    Source0: http://rubygems.org/gems/%{gem_name}-%{version}.gem

* %description 80 chars wrap
  - In %description, there should be no lines longer than 80 characters [1].

* Missing %changelog
  - Please add %changelog section into your .spec file [2].

* -doc subpackage
  - Please consider to move documentation into -doc subpackage [3].


[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
[3]
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#PackageDocumentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]