Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: icu4j https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199592 vivekl@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vivekl@xxxxxxxxxx |mwringe@xxxxxxxxxx ------- Additional Comments From vivekl@xxxxxxxxxx 2007-02-14 10:36 EST ------- (In reply to comment #21) > (In reply to comment #20) > > ... > > - for non-numerics (pre-release, CVS snapshots, etc.), see > > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PackageRelease > > . 0:3.4.5-2jpp.1 -> 0:3.4.5-2jpp.2%{?dist} to be inline with > > http://fedoraproject.org/wiki/PackagingDrafts/ExceptionJPackage Looks good, 0:3.4.5-2jpp.1.fc7 is rpm newer > > ... > > X * license field matches the actual license. > > + The license according > > http://www-306.ibm.com/software/globalization/icu/license.jsp is X License > Yeah, the X License = X.net License = X11 License = MIT License > Only the MIT license and the X.net License appear in the offical rpmlint > license list. Should this be called what the project calls it "X license" > or should the MIT license be used instead since rpmlint likes it better? > MIT style seems correct to me for this package > > W: icu4j-eclipse no-documentation > > . There should probably be an EPL file in the eclipse subpackage that needs > > to be added > The plugin should be under the X license since this is the license of the > project. This has now been added OK > > X package should own all directories and files > > . /usr/lib/eclipse should be owned by libswt3-gtk2 in the latest update to it, Please apply bkonrath's suggestion above > > add a require for it > > . jpackage-utils is needed for the javadoc and base package since it needs > > /usr/share/java{,doc}. Also please apply the fix to the src.zip that bkonrath mentioned Everything else looks good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review