[Bug 829097] Review Request: sicktoolbox - The SICK LIDAR Toolbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=829097

Volker Fröhlich <volker27@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27@xxxxxx

--- Comment #1 from Volker Fröhlich <volker27@xxxxxx> ---
Did you try to submit your patch?

Don't the other methods work that are described in
http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath ?

rm -rf %{buildroot} is not necessary.

It must be:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

I noticed the PDFs make up most of the size of the package. Consider a
separated -doc sub-package, as mentioned here:
http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

THANKS, NEWS and the examples directory could also be included.

I'd like to recommend registering the libray on http://upstream-tracker.org to
keep track of ABI breakage.

You can remove the trailing slash from the URL, if you want.

Odd findings: "ld_config" sounds a lot like ldconfig. The version numbers that
is part of the include-directories also surprised me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]