[Bug 841266] Review Request: plink - whole genome association analysis toolset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=841266

--- Comment #5 from Volker Fröhlich <volker27@xxxxxx> ---
The license must be stated as "GPLv2".
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing

The build does not respect Fedora's optflags.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

What is it about the R plug-in?

There are a couple of compiler warnings that could be dealt with.

Please use the name and version macro in the Source0 line.

Drop the two Requires.
http://fedoraproject.org/wiki/Packaging:Guidelines#Requires

install -m 0755 plink %{buildroot}%{_sbindir}/plink should be fine.

Why is that installed to sbindir?

Add COPYING.txt and README via the doc macro.

I noticed a jar file in the tarball. What is it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]