[Bug 821917] Review Request: mu - maildir utility with Emacs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=821917

--- Comment #4 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
Thanks for upgrading.

rpmbuild -ba runs fine on my Fedora17 system and creates 4 rpms and one srpm
package. The rpmlint results are these:


rpmlint mu-0.9.8.5-1.fc17.src.rpm
mu.src: W: spelling-error %description -l en_US maildirs -> airmails
mu.src: W: invalid-url Source0:
http://mu0.googlecode.com/files/mu-0.9.8.5.tar.gz HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint mu-0.9.8.5-1.fc17.x86_64.rpm
mu.x86_64: E: explicit-lib-dependency glib2
mu.x86_64: E: explicit-lib-dependency libuuid
mu.x86_64: E: explicit-lib-dependency xapian-core-libs
mu.x86_64: E: explicit-lib-dependency zlib
mu.x86_64: W: spelling-error %description -l en_US maildirs -> airmails
mu.x86_64: W: spelling-error %description -l en_US emacs -> Emacs, macs, maces
mu.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mu ['/usr/lib64']
mu.x86_64: W: manual-page-warning /usr/share/man/man1/mu-find.1.gz 54: cannot
use newline as a starting delimiter
mu.x86_64: W: manual-page-warning /usr/share/man/man1/mu-find.1.gz 405:
warning: macro `T' not defined
mu.x86_64: W: manual-page-warning /usr/share/man/man1/mu-cfind.1.gz 101:
warning: macro `sh' not defined
mu.x86_64: W: manual-page-warning /usr/share/man/man1/mu-cfind.1.gz 103:
warning: macro `si' not defined
mu.x86_64: E: standard-dir-owned-by-package /usr/share/man/man5
mu.x86_64: W: manual-page-warning /usr/share/man/man1/mu-index.1.gz 137:
warning: macro `si' not defined
mu.x86_64: E: info-files-without-install-info-postin
/usr/share/info/mu4e.info.gz
mu.x86_64: E: info-files-without-install-info-postun
/usr/share/info/mu4e.info.gz
mu.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
1 packages and 0 specfiles checked; 9 errors, 7 warnings.

rpmlint emacs-mu4e-0.9.8.5-1.fc17.noarch.rpm
emacs-mu4e.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint emacs-mu4e-el-0.9.8.5-1.fc17.noarch.rpm
emacs-mu4e-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Ellis
emacs-mu4e-el.noarch: W: no-documentation
emacs-mu4e-el.noarch: E: incorrect-fsf-address
/usr/share/emacs/site-lisp/mu4e/mu4e-speedbar.el
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

rpmlint mu-debuginfo-0.9.8.5-1.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Please try to address the warnings and errors mentioned.
The warning about the invalid-url on googlecode can be ignored for now. This is
a known rpmlint problem, see:
https://bugzilla.redhat.com/show_bug.cgi?id=767739

Some additional comments on your spec file:

Two different styles of macros are mixed in this spec file, i.e.:
$RPM_BUILD_ROOT%{_datadir}/info/dir

please choose a consistent style, i.e. use:
%{buildroot}%{_datadir}/info/dir
(see http://fedoraproject.org/wiki/Packaging:Guidelines, 
 1.35.1 Using %{buildroot} and %{optflags} vs $RPM_BUILD_ROOT and
$RPM_OPT_FLAGS)

the install-info commands seem issued on the wrong subpackage.
mu4e.info.gz is part of the mu rpm, not the emacs-mu4e rpm

The incorrect-fsf-address error is explained here:
https://fedoraproject.org/wiki/Common_Rpmlint_issues

The warnings on the man pages should probably be passed on to upstream.

Please don't own the standard man page directories, only the files below them.

Finally I wonder why the *.elc files are provided in both the
emacs-mu4e-el and emacs-mu4e package. 
It seems to me this may confuse the rpm database in case both packages are
installed (but I'm not completely sure, so if anyone has more experience with
this, please step in).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]