https://bugzilla.redhat.com/show_bug.cgi?id=865995 Jørn Lomax <northlomax@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |northlomax@xxxxxxxxx --- Comment #1 from Jørn Lomax <northlomax@xxxxxxxxx> --- Couple of things I would like to see be fixed before I post the full review: Add a comment that you have (if you have) contacted upstream about incorrect fsf address. Please use desktop-file-install to install the desktop file, or at the very least run desktop-file-validate. (see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop for more info) And if I want to be picky, you can substitute "non-session-manager" with %{name} for the Patch0 line -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review