[Bug 865915] Review Request: python-py9p - Pure Python implementation of 9p protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=865915

--- Comment #5 from Saveliev Peter <peet@xxxxxxxxxx> ---
(In reply to comment #4)
<skip />
> python-py9p.noarch: E: non-executable-script
> /usr/lib/python2.7/site-packages/py9p/sk1.py 0644L /usr/bin/env
> 
> ^^^ I don't think this is a blocker but I don't see any reason why these
> files should be executed directly. So could you, please, add something like
> this to the %prep section:
> 
> sed -i -e "1d" py9p/pki.py py9p/py9p.py py9p/sk1.py

Since I maintain this fork, I think, we can just remove the line from the
source code: it is of no use here.

<skip /> 
> I don't see any issues (except the small almost cosmetic one with
> /usr/bin/enb noted above) so this package is
> 
> APPROVED.

Thanks. Can I remove the «env» clause in this build, or should do in the next
one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]