https://bugzilla.redhat.com/show_bug.cgi?id=810676 Pavel Zhukov <pavel@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pavel@xxxxxxxxxxx | |) | --- Comment #29 from Pavel Zhukov <pavel@xxxxxxxxxxx> --- > aws-doc.x86_64: E: devel-dependency aws(x86-64)-devel removed > aws-tools.x86_64: W: no-manual-page-for-binary wsdl2aws > → See the separate point below. > aws.src: W: invalid-url Source1: aws-fedora.tgz > → I assume that you're going to check that file into Git. Otherwise you > would need to provide a URL to it. Added github URL to comment > · The package must meet the Packaging Guidelines. > → ISSUES: > · The -doc subpackage should be in the Documentation group. fixed > · The comment about the SSL versions patch needs to be expanded to > explain whether you have sent the patch upstream, or whether it's > Fedora-specific for some reason. fixed > · It's unclear whether IPv6 is enabled. build_aws.gpr points to both > aws-net-std__gnat.adb and aws-net-std__ipv6.adb as implementations of > AWS.Net.Std, and it's not easy to know which of them takes effect. aws.gpr > only points to aws-net-std__gnat.adb. FIXME > · The License field in the package spec file must match the actual license. > → ISSUE: As far as I can see the license should be "GPLv3+ with exceptions > and GPLv2+" on the main package, and "GPLv3+" on aws-tools. (Memory_Streams > is GPLv2+.) Fixed > > · If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package must be included in %doc. > → NOTE: A copy of COPYING3 must be included in aws-doc if its dependency > on aws-devel is removed. COPYING3 is bringing with main package all subpackages are depends from main. Do I have to inclide COPYING3 in aws-doc as well? > · The package must NOT bundle copies of system libraries. > > → ISSUE: Zlib-Ada is now packaged so include/zlib* must be deleted. "-lz" > should be deleted from build_aws.gpr, and «with "zlib_ada";» added to > build_aws.gpr and aws.gpr. The build dependencies and the dependencies of > aws-devel must reflect this. Fixed > > Ada-specific MUST items: > > · The package must have "BuildRequires: gcc-gnat". > → ISSUE: gcc-gnat is missing from the build dependencies. Main and -devel packages depend from fedora-gnat-projects-common which depend from gcc-gnat. package: fedora-gnat-project-common.noarch 3.5-1.fc17 dependency: gcc-gnat provider: gcc-gnat.x86_64 4.7.2-2.fc17 > > · If there is a need to prevent attempts to build the package on secondary > architectures where GNAT has not been bootstrapped, then this MUST be done > with "ExclusiveArch: %{GNAT_arches}". > → NOTE: Once the package is imported and the branches have been set up, > please change to "ExclusiveArch: %{GNAT_arches}" in the f17, f18 and master > branches. OK > > · The reviewer should test that the package functions as described. > → ISSUES: Trying to compile the demos reveals several problems: > · aws.gpr tries to import "aws/template_parser", which doesn't exist. > · aws.gpr imports xmlada.gpr, so aws-devel must require xmlada-devel. > · AWS speces reference Templates Parser speces, so aws.gpr must import > templates_parser.gpr and aws-devel must require templates_parser-devel. > · aws.gpr points to aws-net-ssl__openssl.adb instead of > aws-net-ssl__gnutls.adb. Ohh. I'll patch samples :( > · The package should contain man pages for binaries/scripts. If it doesn't, > work with upstream to add them where they make sense. > → ISSUE: There are no man pages for awsres and wsdl2aws. Debian has man > pages however, so you should try to adapt those for Fedora. In a quick check > I found one thing that needs to be adjusted: They refer to the manual in the > -doc subpackage, but Debian's package has a different name. You could change > it to "aws-doc", but it might be better to remove the package name so that > the man pages can be upstreamed. I'll check debian package but I wouldn't like to bring man pages from anywhere and patch it. It's hard to follow any changes in man pages or something else. > > Common sense stuff not mentioned in the guidelines: > > · ISSUE: The group of the -tools subpackage is wrong. The tools aren't > libraries. I think "Applications/Text" is the best choice. OK > · ISSUE: The -doc subpackage should be noarch (and thus not use _isa). Fixed -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review