[Bug 797203] Review Request: augeas-vala - Vala bindings for augeas.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=797203

--- Comment #8 from Fabian Deutsch <fabian.deutsch@xxxxxx> ---
(In reply to comment #7)
> Based on the f18 build:
> 
> $ rpmlint -i -v *
> augeas-vala.src: I: checking
> augeas-vala.src: I: checking-url
> http://www.gitorious.org/valastuff/augeas-vala/ (timeout 10 seconds)
> augeas-vala.src: W: invalid-url Source0: augeas-vala-0.10.0-3.tar.gz
> The value should be a valid, public HTTP, HTTPS, or FTP URL.

That's weird - gitorious is online :)

> augeas-vala.noarch: I: checking
> augeas-vala.noarch: E: devel-dependency augeas-devel
> Your package has a dependency on a devel package but it's not a devel package
> itself.

rpmlint complains, but it's needed (this package provides binding for the devel
 libraries, therefor we need a require on augeas-devel)

> augeas-vala.noarch: I: checking-url
> http://www.gitorious.org/valastuff/augeas-vala/ (timeout 10 seconds)
> augeas-vala.noarch: E: script-without-shebang
> /usr/share/vala/vapi/augeas.vapi
> This text file has executable bits set or is located in a path dedicated for
> executables, but lacks a shebang and cannot thus be executed.  If the file is
> meant to be an executable script, add the shebang, otherwise remove the
> executable bits or move the file elsewhere.

the executable is not set (checked that before) and the other vapis are also
kept in that dir ... but will look into it ..

> augeas-vala.noarch: E: incorrect-fsf-address
> /usr/share/doc/augeas-vala-0.10.0/COPYING.LIB
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.

yep, ack

> augeas-vala.noarch: E: script-without-shebang
> /usr/share/vala/vapi/augeas.deps
> This text file has executable bits set or is located in a path dedicated for
> executables, but lacks a shebang and cannot thus be executed.  If the file is
> meant to be an executable script, add the shebang, otherwise remove the
> executable bits or move the file elsewhere.

see above

> augeas-vala.spec: W: invalid-url Source0: augeas-vala-0.10.0-3.tar.gz
> The value should be a valid, public HTTP, HTTPS, or FTP URL.
>
> 
> The invalid-source warning is nothing of interest, because we have a Git
> checkout.
> Also the wrong FSF address doesn't need to be fixed for the time being,
> because we don't touch any provided license info. But consider to fix it in
> the next upstream release.

ack

> There remain the executable bits in /usr/share/vala/vapi/augeas.vapi and
> /usr/share/vala/vapi/augeas.deps. Remove them, if we may assume these files
> haven't to be executed directly.


mh automak must set them, i'll check as said above ..

> BTW, to avoid some patching the sources: You are the upstream author, you
> could roll a new upstream release instantly ;)

definetly. danke for your patience, mario :)

btw. are you on #fedora-de?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]