[Bug 865241] Review Request: liblangtag - library to access tags for identifying languages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=865241

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Koji scratch build for f19 is
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4580604

+ rpmlint on rpms gave
liblangtag.src: W: spelling-error %description -l en_US subtag -> sub tag,
sub-tag, subtotal
liblangtag.src: W: spelling-error %description -l en_US extlang -> extolling
liblangtag.src: W: spelling-error %description -l en_US canonicalizing ->
cannibalizing, canonizing, canalizing
liblangtag.x86_64: W: spelling-error %description -l en_US subtag -> sub tag,
sub-tag, subtotal
liblangtag.x86_64: W: spelling-error %description -l en_US extlang -> extolling
liblangtag.x86_64: W: spelling-error %description -l en_US canonicalizing ->
cannibalizing, canonizing, canalizing
liblangtag-devel.x86_64: W: no-documentation
liblangtag-devel.x86_64: E: incorrect-fsf-address
/usr/include/liblangtag/lt-ext-module-data.h
4 packages and 0 specfiles checked; 1 errors, 7 warnings.
==> Good to contact upstream for incorrect-fsf-address if not fixed already in
upstream

+ Source verified with upstream as (sha256sum)
47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d 
liblangtag-0.3.tar.bz2
47d3bf2824df0df409219d2061c99adac11019151315e5372f6844bba1f4de4d 
../SOURCES/liblangtag-0.3.tar.bz2

+ Follows packaging guidelines

Suggestions:
1) Good to preserve timestamps of installed files from source as
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) You can add author's reply as a text file in %doc for license clarification 

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]