[Bug 864464] Review Request: python-tox - virtualenv-based automation of test activities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=864464

--- Comment #11 from Lorenzo Gil Sanchez <lorenzo.gil.sanchez@xxxxxxxxx> ---
(In reply to comment #10)
> Lorenzo,
> 
> BuildRequires means to build the RPM, as opposed to Requires, which is just
> for run time. Even the tox testsuite stage is considered part of the
> rpmbuild, and thus external packages like pypy and such should be used from
> the external system, not explicitly included as source.
> 
> Can you modify your spec to use the files from the base system, possibly via
> a symlink, instead of importing the sources?

Unfortunately Tox needs 'source distributions' of pytest, py and virtualenv. A
Python 'source distribution' is different from a package installed on a system.
For example, a source distribution contains the setup.py file, which is not
included in the base system when you install the packages python-py, pytest or
python-virtualenv.

Maybe the easiest solution would be to skip the %test phase for this package.

By the way, we still have the issue of the python3-tox package, which depends
on the non existing package python3-virtualenv. Adam, you said that the tests
run with the python3-tox package but I wonder if the tests does not cover the
code path I spotted in the comment #4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]