https://bugzilla.redhat.com/show_bug.cgi?id=864464 --- Comment #7 from Matthias Runge <mrunge@xxxxxxxxxx> --- (In reply to comment #4) > > Then the python 2 & 3 version: > > http://lorenzogil.com/rpms/python-tox/python-tox-py3.spec > > > IMHO the difficult part on this package is the %check phase (which is > avoided in Matthias spec for good reasons). Tox tries to fetch some packages > from Pypi in the 'python setup.py test' command since the tox.ini file has > the following deps: > > [testenv] > commands=py.test --junitxml={envlogdir}/junit-{envname}.xml {posargs} > deps=pytest > py > > It also uses virtualenv when running the tests. It doesn't matter if you > already have the python-virtualenv package installed. This package is on the > BuildRequires because is also needed in the python setup.py build step. > Two remarks to your spec: - You're mixing sources and requirements. I'd recomment, not to use these here, but just to require those as build requirements. Source1: http://pypi.python.org/packages/source/p/py/py-1.4.9.zip Source2: http://pypi.python.org/packages/source/p/pytest/pytest-2.2.4.zip Source3: http://pypi.python.org/packages/source/v/virtualenv/virtualenv-1.8.2.tar.gz in prep you made: cp -a . %{py3dir} find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python}|' One find is too much. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review