https://bugzilla.redhat.com/show_bug.cgi?id=864535 --- Comment #3 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #2) > Yeah. This package is only for F18 and rawhide. Not only because the > libvirt-gconfig dependency as you've pointed out, but the whole > libvirt-glib. It uses APIs that were added in libvirt-glib-1.3.0 release > (libvirt-gobject in particular). Okay, thanks for the quick response. A few very important points below: LEGEND: X=Met, !=Not met, ?=Not a blocker but should be fixed ============================================================= [X] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] mcpierce@mcpierce-laptop:review $ rpmlint *rpm libvirt-designer.src: W: file-size-mismatch libvirt-designer-0.0.1.tar.gz = 410005, http://libvirt.org/sources/designer/libvirt-designer-0.0.1.tar.gz = 418435 4 packages and 0 specfiles checked; 0 errors, 1 warnings. [X] MUST: The package must be named according to the Package Naming Guidelines . [X] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . [!] MUST: The package must meet the Packaging Guidelines . The changelog lists Dan Berrange as the packager, but the package review is from Michal Privoznik. The changelog should name the packager. [X] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [X] MUST: The License field in the package spec file must match the actual license. [3] [X] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] [X] MUST: The spec file must be written in American English. [5] [X] MUST: The spec file for the package MUST be legible. [6] [!] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. The source file in the SRPM does not match the upstream source: mcpierce@mcpierce-laptop:temp $ ll libvirt-designer*tar* -rw-rw-r--. 1 mcpierce mcpierce 410005 Oct 9 14:12 libvirt-designer-0.0.1.tar.gz -rw-rw-r--. 1 mcpierce mcpierce 418435 Oct 9 06:28 libvirt-designer-0.0.1.tar.gz-downloaded mcpierce@mcpierce-laptop:temp $ md5sum libvirt-designer-0.0.1.tar.gz libvirt-designer-0.0.1.tar.gz-downloaded d26c5a4f148ba37ccbd1d95577cb97a7 libvirt-designer-0.0.1.tar.gz 634b50ad539ab6b5c0188644780578d3 libvirt-designer-0.0.1.tar.gz-downloaded sy [X] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] Since this is only for F18+, be sure when it finally is approved to only request F18+ git modules. [X] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [X] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] [X] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] [X] MUST: Packages must NOT bundle copies of system libraries.[11] [X] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] [X] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] [X] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] [X] MUST: Each package must consistently use macros. [16] [X] MUST: The package must contain code, or permissable content. [17] [?] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] There are documentation files in the -devel package. Maybe consider putting them into a -devel-doc package. [X] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] [X] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[19] [!] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] Both libvirt-designer-devel and libvirt-design-libs provide /usr/lib{64}/libvirt-designer-1.0.so* [X] MUST: All filenames in rpm packages must be valid UTF-8. [24] -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review