[Bug 864464] Review Request: python-tox - virtualenv-based automation of test activities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=864464

Lorenzo Gil Sanchez <lorenzo.gil.sanchez@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lorenzo.gil.sanchez@gmail.c
                   |                            |om

--- Comment #4 from Lorenzo Gil Sanchez <lorenzo.gil.sanchez@xxxxxxxxx> ---
I can't believe this submission just happened today! I spent last week creating
my first package for Fedora and I went for python-tox.

Anyway, I'll put links to my specs and srpms just in case they can be useful.

First the python 2 only version:

# SPEC:
http://lorenzogil.com/rpms/python-tox/python-tox.spec
# SRPM:
http://lorenzogil.com/rpms/python-tox/python-tox-1.4.2-1.fc17.src.rpm
# Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4575039


Then the python 2 & 3 version:

http://lorenzogil.com/rpms/python-tox/python-tox-py3.spec


IMHO the difficult part on this package is the %check phase (which is avoided
in Matthias spec for good reasons). Tox tries to fetch some packages from Pypi
in the 'python setup.py test' command since the tox.ini file has the following
deps:

[testenv]
commands=py.test --junitxml={envlogdir}/junit-{envname}.xml {posargs}
deps=pytest
     py

It also uses virtualenv when running the tests. It doesn't matter if you
already have the python-virtualenv package installed. This package is on the
BuildRequires because is also needed in the python setup.py build step.

About the python 3 version I ended removing it because it would Requires
python3-virtualenv and it does not exist. You can see this dependency hidden in
the following line:
https://bitbucket.org/hpk42/tox/src/b6d3b82545e4/tox/_venv.py?at=default#cl-173

If that line is ever called with a python3 interpreter you will get this error:

>>> import imp
>>> imp.find_module('virtualenv')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named virtualenv


I hope this information helps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]