Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zhcon - A Fast Console CJK System Using FrameBuffer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228450 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-14 03:41 EST ------- (In reply to comment #6) > I have updated the files, you can download them again. Umm.. where? Note: please bump the release number every time you fix the spec file. * chown > zhcon need the 4755 permission to access some devices. - I checked the spec from Parag, still failing mockbuild on FC7 i386. Well, src/Makefile.in still says: --------------------------------------- install-exec-local: chmod 4755 $(bindir)/zhcon --------------------------------------- It seems that automake is not called recursively. So please apply a patch for Makefile.in. * %attr - And use %attr for binaries which needs setuid/setgid bits. Unless using %attr, rpmbuild removes the setuid/setgid bits on creating rpm. - dist tag Using dist tag %{?dist} makes it easier to manage spec files on different branches and this is recommended. http://fedoraproject.org/wiki/Packaging/DistTag - quiet setup - setup is not quiet. Please use "%setup -q" - and please make it quite to expand files from tarball i.e. Don't use "zxvf" for tar. and please use "zxf". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review