[Bug 863983] Review Request: ninja-ide - Ninja IDE for Python development

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=863983

Eduardo Echeverria <echevemaster@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |echevemaster@xxxxxxxxx

--- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi Nikos:
Initial Comments:
rpmlint -v ninja-ide*
ninja-ide.noarch: I: checking
ninja-ide.noarch: I: checking-url http://www.ninja-ide.org/ (timeout 10
seconds)
ninja-ide.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/ninja_ide/dependencies/pep8mod.py 0644L
/usr/bin/env
ninja-ide.noarch: W: no-manual-page-for-binary ninja-ide
ninja-ide.src: I: checking
ninja-ide.src: I: checking-url http://www.ninja-ide.org/ (timeout 10 seconds)
ninja-ide.src: I: checking-url
https://github.com/downloads/ninja-ide/ninja-ide/ninja-ide-v2.1.1.zip (timeout
10 seconds)
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

- You could use
BuildRequires: python2-devel
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

- Remove 
%defattr(-,root,root,-) is applicable only for EPEL5

the section %docs generally should be collocated after %files

- Add %check section
Require python-inotify for test (BuildRequires)

Best Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]