Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zhcon - A Fast Console CJK System Using FrameBuffer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228450 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-14 02:49 EST ------- Well, * Specify the location of the source. * Don't use "zhcon-0.2.5-to-0.2.6.diff". Please use the source 0.2.6 directly. * The content of zhcon-0.2.6-path.patch is wrong. ------------------------------------------------ + $(INSTALL_DATA) $(srcdir)/zhcon.conf $(DESTDIR)$(prefix)/etc/zhcon.conf ------------------------------------------------ - The location of $(prefix)/etc/zhcon.conf is not right. - Note: the location of conf file is hardcoded. From src/zhcon.cpp: ------------------------------------------------ 124 if (access(cfgfile.c_str(), R_OK) != 0) 125 cfgfile = "/etc/zhcon.conf"; 126 ------------------------------------------------ Some reviewers say that it would be better to use: ------------------------------------------------ %{__sed} -i -e 's|/etc/zhcon.conf|%{_sysconfdir}/zhcon.conf|' \ src/zhcon.cpp ------------------------------------------------ to use rpm macro correctly. - And.. please avoid to use autotools as much as possible. i.e. when it is possible to apply a patch against not Makefile.am but Makefile.in, please make a patch for Makefile.in and don't call automake etc. For chown, I will check later. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review