[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=863719

--- Comment #2 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> ---
(In reply to comment #1)
---[snip]---
> 
> Ok so far. Some issues, though:
> 
> Requires:       %{name} = %{version}-%{release}
> has to be
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> It's an arch dependent package, that's why the "isa" macro must be present.
> See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Done.

> The %defattr lines are obsolete. It is only needed for rpm < 4.4, and even
> EPEL 5 ships rpm-4.4.2. Just remove them.

Also done but someone needs to update the EPEL6 rpmlint (0.94-2.el6) as it
reports the defattr issue as error:
----------
$ rpmlint ivykis-0.30.4-2.el6.src.rpm 
...
ivykis.src:68: E: files-attr-not-set
ivykis.src:69: E: files-attr-not-set
ivykis.src:72: E: files-attr-not-set
ivykis.src:73: E: files-attr-not-set
ivykis.src:74: E: files-attr-not-set
ivykis.src:75: E: files-attr-not-set
1 packages and 0 specfiles checked; 6 errors, 3 warnings. 
----------


New SRPM:
http://um-pe09-2.di.uminho.pt/fedora/ivykis-0.30.4-2.el6.src.rpm
and specfile:
http://um-pe09-2.di.uminho.pt/fedora/ivykis.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]