[Bug 863756] Review Request: python-xmlbuilder - A python xml/(x)html builder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=863756

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
$ rpmlint -i -v *
python-xmlbuilder.src: I: checking
python-xmlbuilder.src: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.src: W: spelling-error Summary(en_US) html -> HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.src: W: spelling-error %description -l en_US xml -> XML, ml,
x ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.src: W: spelling-error %description -l en_US pythonomic ->
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.src: I: checking-url http://pypi.python.org/pypi/xmlbuilder
(timeout 10 seconds)
python-xmlbuilder.src: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
python-xmlbuilder.noarch: I: checking
python-xmlbuilder.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.noarch: W: spelling-error Summary(en_US) html -> HTML, ht ml,
ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.noarch: W: spelling-error %description -l en_US xml -> XML,
ml, x ml
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.noarch: W: spelling-error %description -l en_US pythonomic ->
nonrhythmic
The value of this tag appears to be misspelled. Please double-check.

python-xmlbuilder.noarch: I: checking-url
http://pypi.python.org/pypi/xmlbuilder (timeout 10 seconds)
python-xmlbuilder.spec: I: checking-url
http://pypi.python.org/packages/source/x/xmlbuilder/xmlbuilder-1.0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

Some ignorable spelling errors.


The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):

rm -rf %{srcname}.egg-info

See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.


python-setuptools-devel in BR could be replaced by python-setuptools because
the latter provides python-setuptools-devel anyway.

The date in %changelog is wrong, should be "Sun Oct 07 2012".

The description could be tweaked a bit. My suggestion:

XMLBuilder is a tiny library built on top of ElementTree.TreeBuilder to make
XML files creation more pythonomic. `XMLBuilder` uses the `with` statement and
attribute access to define the XML document structure.


Taking this for a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]