https://bugzilla.redhat.com/show_bug.cgi?id=851267 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #2 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Mattias: Initial Comments: >From what I see, you have intentions of supporting EPEL5. - If so,please add buildroot Example: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag - Even if you use macros correctly how $RPM_BUILD_ROOT, we have a macro that is commonly used %{buildroot}, is only a suggestion. - Reorder the %docs section right after the %files section. - Add %defattr in %files. (for EPEL5) - Add %clean section (rm -rf %{buildroot}) - Don't Require desktop-file-utils for update-desktop-database http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database - Don't having man pages for the binaries, commonly it searches a distro that if may to having disposal this pages, but you have to notify upstream or work with he for add them. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Man_pages Best Regards -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review