Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-sun - Sun clock plugin for GKrellM https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228294 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2007-02-13 23:14 EST ------- OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: fbbf5c23a3966b2e16a2bab19a0885b7 gkrellsun-1.0.0.tar.gz fbbf5c23a3966b2e16a2bab19a0885b7 gkrellsun-1.0.0.tar.gz.1 OK - BuildRequires correct See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Default perms are %defattr(-, root, root, 0755) Can that be changed to: %defattr(-, root, root, -) 2. Please use the one true build root(tm): %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review