https://bugzilla.redhat.com/show_bug.cgi?id=819184 --- Comment #4 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> --- (In reply to comment #1) > The development symlink should not be there, as there are no headers. I > suggest to just delete it. done. > Since one of the seemingly private libraries is installed in libdir, rpmlint > complains about not running ldconfig. If this library really is private, it > should ideally not be in libdir, but in the subdirectory along with the > others. The provides of the final package also contain all those private > libraries; that should be filtered. I filtered out libQupZilla and the plugins and run ldconfig to make rpmlint happy. Attempts to move the library to %{_libdir}/%{name}/ have been too cumbersome. > %dir %{_libdir}/qupzilla and %{_libdir}/qupzilla/*.so could be simplified to > %{_libdir}/qupzilla. Probably use the name macro here. done. > There are a couple of warnings for the desktop file. I am using desktop-file-install now as I also add x-scheme-handlers. > You should also run a > scriplet for the icons installed in datadir/icons D'oh, of course. > Consider to include README.md, as it contains some useful information. done. > I suggest to add a -f where you're deleting the "useless plugin", just in > case it disappears in a future release. done. > Buildroot rm in the install section, clean section and buildroot definition > are definitely not necessary, as you BR qt >= 4.7, which is only in Fedora. done. > I think the package could have a better Summary, but it's not a must. What do you think could be improved? > I noticed, there are a couple of plug-ins and private libraries with BSD > licenses. Changed the license tag to "GPLv3+ and BSD". > Are USE_WEBGL and USE_QTWEBKIT_2_2 options of interest? Both should work, I > think. Yes, it does and they add interesting features. New package: * Sat Oct 06 2012 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> - 1.3.5-1 - Update to 1.3.5 - Enable WebGL (USE_WEBGL) - Enable geolocation and notification API (USE_QTWEBKIT_2_2) - Change icense tag to "GPLv3+ and BSD" (some plugins are BSD licensed) - Add x-scheme-handlers so qupzilla can be set as default browser - Filter out private requires and provides - Include README.md in %%doc Spec URL: http://cwickert.fedorapeople.org/review/qupzilla.spec SRPM URL: http://cwickert.fedorapeople.org/review/qupzilla-1.3.5-1.fc19.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4566303 $ rpmlint SPECS/qupzilla.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/qupzilla-1.3.5-1.fc17.src.rpm qupzilla.src: W: spelling-error %description -l en_US theming -> teeming, hemming, emitting 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/qupzilla-* qupzilla.x86_64: W: spelling-error %description -l en_US theming -> teeming, hemming, emitting qupzilla.x86_64: W: no-manual-page-for-binary qupzilla 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review