https://bugzilla.redhat.com/show_bug.cgi?id=862216 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- $ rpmlint -i -v * libdivecomputer.src: I: checking libdivecomputer.src: W: spelling-error %description -l en_US Suunto -> Surmount The value of this tag appears to be misspelled. Please double-check. libdivecomputer.src: W: spelling-error %description -l en_US Veo -> Leo, Geo, Veto The value of this tag appears to be misspelled. Please double-check. libdivecomputer.src: W: spelling-error %description -l en_US Backends -> Back ends, Back-ends, Backhands The value of this tag appears to be misspelled. Please double-check. libdivecomputer.src: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer.src:1: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:2: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:3: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:3: W: macro-in-comment %{snapdate} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:3: W: macro-in-comment %{snaphash} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:7: W: macro-in-comment %{snapver} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:92: W: macro-in-comment %setup There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:92: W: macro-in-comment %{name} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src:92: W: macro-in-comment %{snaphash} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.src: I: checking-url http://divesoftware.org/libdc/releases/libdivecomputer-0.2.0.tar.gz (timeout 10 seconds) libdivecomputer.i686: I: checking libdivecomputer.i686: E: explicit-lib-dependency libusb1 You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. libdivecomputer.i686: W: spelling-error %description -l en_US Suunto -> Surmount The value of this tag appears to be misspelled. Please double-check. libdivecomputer.i686: W: spelling-error %description -l en_US Veo -> Leo, Geo, Veto The value of this tag appears to be misspelled. Please double-check. libdivecomputer.i686: W: spelling-error %description -l en_US Backends -> Back ends, Back-ends, Backhands The value of this tag appears to be misspelled. Please double-check. libdivecomputer.i686: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer.i686: W: no-manual-page-for-binary iconhd Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary memomouse Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary puck Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary atom2 Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary solution Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary vyper2 Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary n2ition3 Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary d9 Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary edy Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary frog Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary sensusultra Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary darwin Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary universal Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary smart Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary nemo Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary vtpro Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary ostc Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary aladin Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary veo250 Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary sensuspro Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary vyper Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary eon Each executable in standard binary directories should have a man page. libdivecomputer.i686: W: no-manual-page-for-binary sensus Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: I: checking libdivecomputer.x86_64: E: explicit-lib-dependency libusb1 You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. libdivecomputer.x86_64: W: spelling-error %description -l en_US Suunto -> Surmount The value of this tag appears to be misspelled. Please double-check. libdivecomputer.x86_64: W: spelling-error %description -l en_US Veo -> Leo, Geo, Veto The value of this tag appears to be misspelled. Please double-check. libdivecomputer.x86_64: W: spelling-error %description -l en_US Backends -> Back ends, Back-ends, Backhands The value of this tag appears to be misspelled. Please double-check. libdivecomputer.x86_64: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer.x86_64: W: no-manual-page-for-binary iconhd Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary memomouse Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary puck Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary atom2 Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary solution Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary vyper2 Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary n2ition3 Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary d9 Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary edy Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary frog Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary sensusultra Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary darwin Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary universal Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary smart Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary nemo Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary vtpro Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary ostc Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary aladin Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary veo250 Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary sensuspro Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary vyper Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary eon Each executable in standard binary directories should have a man page. libdivecomputer.x86_64: W: no-manual-page-for-binary sensus Each executable in standard binary directories should have a man page. (none): E: no installed packages by name libdivecomputer-0.2.0.tar.gz libdivecomputer-debuginfo.i686: I: checking libdivecomputer-debuginfo.i686: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-debuginfo.x86_64: I: checking libdivecomputer-debuginfo.x86_64: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-devel.i686: I: checking libdivecomputer-devel.i686: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libdivecomputer-devel.x86_64: I: checking libdivecomputer-devel.x86_64: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libdivecomputer.spec:1: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:2: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:3: W: macro-in-comment %global There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:3: W: macro-in-comment %{snapdate} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:3: W: macro-in-comment %{snaphash} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:7: W: macro-in-comment %{snapver} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:92: W: macro-in-comment %setup There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:92: W: macro-in-comment %{name} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec:92: W: macro-in-comment %{snaphash} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdivecomputer.spec: I: checking-url http://divesoftware.org/libdc/releases/libdivecomputer-0.2.0.tar.gz (timeout 10 seconds) libdivecomputer-static.i686: I: checking libdivecomputer-static.i686: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-static.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libdivecomputer-static.x86_64: I: checking libdivecomputer-static.x86_64: I: checking-url http://divesoftware.org/libdc/ (timeout 10 seconds) libdivecomputer-static.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 9 packages and 1 specfiles checked; 2 errors, 77 warnings. As far as I can see, we have a lot of ignorable warnings, such as macro-in-comment or no-manpage, nothing worth to think about. Some issues: The initial cleaning of buildroot in %install is no longer needed. Please remove. If your package needs libusb1-devel in BuildRequires (and needs that header stuff actually), so to have libusb1 in Requires is not needed. Should be added automatically while building the package. The "later version" clause is included in the source file headers, that's why the license is LGPLv2+ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review