Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: coreutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |twaugh@xxxxxxxxxx CC| |kevin@xxxxxxxxx ------- Additional Comments From kevin@xxxxxxxxx 2007-02-13 21:52 EST ------- Hey Michael. Thanks for helping out reviewing. :) I typically use a template to check things, just to make sure I don't miss anything. Feel free to use my template at: http://www.fedoraproject.org/wiki/KevinFenzi/ReviewTemplate You might also want to look at: http://www.fedoraproject.org/wiki/WarrenTogami/ReviewWithFlags Which is the current review method we are using for these reviews. A few things that jump out at me looking at this: 1. %makeinstall is used. Can 'make DESTDIR=$RPM_BUILD_ROOT install' be used instead? See the wiki for reasons why %makeinstall is bad. 2. Does the: # Remove these old glibc files on upgrade (bug #84090). still apply? I can't read that bug, so its hard to tell. 3. Minor: The Source files should really have 'coreutils-' in front of them. If you install this src.rpm and want to gather the files from SOURCES it's anoying to do so. 4. Is it worth trying to fix bug https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211615 To fix the loop between pam and coreutils as part of this cleanup/review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review