[Bug 849026] Review Request: jam-control - audioserver gui app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=849026

--- Comment #14 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
koji.fedoraproject.org/koji/taskinfo?taskID=4564142


$ rpmlint -i -v *
jam-control.src: I: checking
jam-control.src: W: spelling-error %description -l en_US pulseaudio -> pulse
audio, pulse-audio, pulsation
The value of this tag appears to be misspelled. Please double-check.

jam-control.src: I: checking-url https://gitorious.org/jam-control (timeout 10
seconds)
jam-control.src: I: checking-url
http://jvlomax.fedorapeople.org/jam-control/jam-control-1.01.tar.gz (timeout 10
seconds)
jam-control.noarch: I: checking
jam-control.noarch: I: checking-url https://gitorious.org/jam-control (timeout
10 seconds)
jam-control.noarch: W: no-manual-page-for-binary jam-control
Each executable in standard binary directories should have a man page.

jam-control.spec: I: checking-url
http://jvlomax.fedorapeople.org/jam-control/jam-control-1.01.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Seems to be OK so far (excepting the missing man page, which to fix is not up
to you with your packager's hat on), but build.log says:

warning: File listed twice: /usr/share/jam-control/jackController.py
warning: File listed twice: /usr/share/jam-control/jackDbusController.py
warning: File listed twice: /usr/share/jam-control/jam-control.py
warning: File listed twice: /usr/share/jam-control/main_ui.py
warning: File listed twice: /usr/share/jam-control/pulseController.py
warning: File listed twice: /usr/share/jam-control/util.py

In your %files list, there's the line

%{_datadir}/%{name}

which means the folder itself and its contents. This is followed by explicit
files, which leads to duplicate listings. Either use

%dir %{_datadir}/%{name}

or omit the specific files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]