https://bugzilla.redhat.com/show_bug.cgi?id=851800 leigh scott <leigh123linux@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #12 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- APPROVED Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/compiz See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [ ]: Package contains no bundled libraries. [ ]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [ ]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [ ]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package devel, %package mate [ ]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [ ]: Large documentation files are in a -doc subpackage, if required. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/leigh/Desktop/851800-compiz/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [ ]: Package is named according to the Package Naming Guidelines. [x]: No %config files under /usr. [ ]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [!]: Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/compiz [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [ ]: Package is not relocatable. [ ]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [ ]: Useful -debuginfo package or justification otherwise. ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [ ]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Patch8 (no-more-mate-wm-settings.patch) Patch0 (comiz_mate_fork.patch) Patch3 (composite-cube-logo.patch) Patch4 (fedora-logo.patch) Patch5 (redhat-logo.patch) Source0 (compiz-0.8.8.tar.bz2) Source6 (50-marco-windows.xml) Source4 (50-marco- navigation.xml) Source5 (50-marco-system.xml) [x]: SourceX is a working URL. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: compiz-0.8.8-5.fc19.x86_64.rpm compiz-devel-0.8.8-5.fc19.x86_64.rpm compiz-mate-0.8.8-5.fc19.x86_64.rpm compiz-debuginfo-0.8.8-5.fc19.x86_64.rpm compiz-0.8.8-5.fc19.src.rpm compiz.x86_64: W: spelling-error Summary(en_US) compositing -> composting, com positing, com-positing compiz.x86_64: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing compiz.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-0.8.8/COPYING.GPL compiz.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-0.8.8/COPYING.LGPL compiz.x86_64: W: no-manual-page-for-binary compiz compiz-devel.x86_64: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing compiz-devel.x86_64: W: no-documentation compiz-mate.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k compiz-mate.x86_64: W: no-documentation compiz-mate.x86_64: W: no-manual-page-for-binary compiz-mate-gtk compiz-mate.x86_64: W: no-manual-page-for-binary gtk-window-decorator compiz-mate.x86_64: W: dangerous-command-in-%pre rm compiz-mate.x86_64: W: dangerous-command-in-%post rm compiz.src: W: spelling-error Summary(en_US) compositing -> composting, com positing, com-positing compiz.src: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing 5 packages and 0 specfiles checked; 2 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint compiz-devel compiz-debuginfo compiz-mate compiz compiz-devel.x86_64: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing compiz-devel.x86_64: W: no-documentation compiz-mate.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k compiz-mate.x86_64: W: no-documentation compiz-mate.x86_64: W: no-manual-page-for-binary compiz-mate-gtk compiz-mate.x86_64: W: no-manual-page-for-binary gtk-window-decorator compiz-mate.x86_64: W: dangerous-command-in-%pre rm compiz-mate.x86_64: W: dangerous-command-in-%post rm compiz.x86_64: W: spelling-error Summary(en_US) compositing -> composting, com positing, com-positing compiz.x86_64: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing compiz.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-0.8.8/COPYING.GPL compiz.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-0.8.8/COPYING.LGPL compiz.x86_64: W: no-manual-page-for-binary compiz 4 packages and 0 specfiles checked; 2 errors, 11 warnings. # echo 'rpmlint-done:' Requires -------- compiz-0.8.8-5.fc19.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig desktop-file-utils glx-utils libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXinerama.so.1()(64bit) libXrandr.so.2()(64bit) libXrender.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdecoration.so.0()(64bit) libdl.so.2()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.4)(64bit) libfuse.so.2(FUSE_2.5)(64bit) libfuse.so.2(FUSE_2.6)(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstartup-notification-1.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) system-logos compiz-devel-0.8.8-5.fc19.x86_64.rpm (rpmlib, GLIBC filtered): /usr/bin/pkg-config compiz(x86-64) = 0.8.8-5.fc19 libICE-devel libSM-devel libXcomposite-devel libXdamage-devel libXfixes-devel libXinerama-devel libXrandr-devel libdecoration.so.0()(64bit) libxml2-devel libxslt-devel pkgconfig pkgconfig(compiz) pkgconfig(ice) pkgconfig(libstartup-notification-1.0) >= 0.7 pkgconfig(libxml-2.0) pkgconfig(libxslt) pkgconfig(sm) pkgconfig(x11) pkgconfig(xcomposite) pkgconfig(xdamage) pkgconfig(xext) pkgconfig(xfixes) pkgconfig(xinerama) pkgconfig(xrandr) pkgconfig(xrender) startup-notification-devel compiz-mate-0.8.8-5.fc19.x86_64.rpm (rpmlib, GLIBC filtered): /bin/bash /bin/sh compiz(x86-64) = 0.8.8 config(compiz-mate) = 0.8.8-5.fc19 libX11.so.6()(64bit) libXrender.so.1()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdecoration.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libmarco-private.so.0()(64bit) libmateconf-2.so.4()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) librsvg-2.so.2()(64bit) libwnck-1.so.22()(64bit) mate-conf rtld(GNU_HASH) compiz-debuginfo-0.8.8-5.fc19.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- compiz-0.8.8-5.fc19.x86_64.rpm: compiz = 0.8.8-5.fc19 compiz(x86-64) = 0.8.8-5.fc19 libblur.so()(64bit) libclone.so()(64bit) libcommands.so()(64bit) libcube.so()(64bit) libdbus.so()(64bit) libdecoration.so()(64bit) libdecoration.so.0()(64bit) libfade.so()(64bit) libfs.so()(64bit) libini.so()(64bit) libinotify.so()(64bit) libminimize.so()(64bit) libmove.so()(64bit) libobs.so()(64bit) libplace.so()(64bit) libpng.so()(64bit) libregex.so()(64bit) libresize.so()(64bit) librotate.so()(64bit) libscale.so()(64bit) libscreenshot.so()(64bit) libswitcher.so()(64bit) libvideo.so()(64bit) libwall.so()(64bit) libwater.so()(64bit) libwobbly.so()(64bit) libzoom.so()(64bit) compiz-devel-0.8.8-5.fc19.x86_64.rpm: compiz-devel = 0.8.8-5.fc19 compiz-devel(x86-64) = 0.8.8-5.fc19 pkgconfig(compiz) = 0.8.8 pkgconfig(compiz-cube) = 0.8.8 pkgconfig(compiz-mateconf) = 0.8.8 pkgconfig(compiz-scale) = 0.8.8 pkgconfig(libdecoration) = 0.8.8 compiz-mate-0.8.8-5.fc19.x86_64.rpm: compiz-mate = 0.8.8-5.fc19 compiz-mate(x86-64) = 0.8.8-5.fc19 config(compiz-mate) = 0.8.8-5.fc19 libannotate.so()(64bit) libglib.so()(64bit) libmatecompat.so()(64bit) libmateconf.so()(64bit) libsvg.so()(64bit) compiz-debuginfo-0.8.8-5.fc19.x86_64.rpm: compiz-debuginfo = 0.8.8-5.fc19 compiz-debuginfo(x86-64) = 0.8.8-5.fc19 Unversioned so-files -------------------- compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libblur.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libclone.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libcommands.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libcube.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libdbus.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libdecoration.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libfade.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libfs.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libini.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libinotify.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libminimize.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libmove.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libobs.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libplace.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libpng.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libregex.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libresize.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/librotate.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libscale.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libscreenshot.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libswitcher.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libvideo.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libwall.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libwater.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libwobbly.so compiz-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libzoom.so compiz-mate-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libannotate.so compiz-mate-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libglib.so compiz-mate-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libmatecompat.so compiz-mate-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libmateconf.so compiz-mate-0.8.8-5.fc19.x86_64.rpm: /usr/lib64/compiz/libsvg.so MD5-sum check ------------- http://releases.compiz.org/0.8.8/compiz-0.8.8.tar.bz2 : CHECKSUM(SHA256) this package : 3ba555b0d6d536850a227d37d6ebc5cd5b15ee5bad83d7956529a27b870977e3 CHECKSUM(SHA256) upstream package : 3ba555b0d6d536850a227d37d6ebc5cd5b15ee5bad83d7956529a27b870977e3 Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 851800 Please remove the (noreplace) when you import %config(noreplace) %{_sysconfdir}/mateconf/schemas/*.schemas -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review