Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-it - Italian hunspell dictionaries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228483 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | Flag| |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-13 18:47 EST ------- Cosmetic: you could dump %define upstreamid 20060731 since you are not using it. GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum a20e97120fc4c9a57a99473317ca378bac9770f1 italiano_2_3_beta_2006_07_23.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 3 text files) - the license GPL stated in the tag is the same as the web site says and is included in the package - the package includes only 2 files (word lists) + several small text files, so no need for separate -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - nothing in %doc affects runtime - no need for .desktop file APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review