https://bugzilla.redhat.com/show_bug.cgi?id=859994 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Hi Imre, I am not sponsor, so I can't sponsor you, but here are some comments: * Newer upstream version available - There is already 2.0.3 release available. Please consider update prior importing into Fedora * The package should own all directories - In -doc subpackage, you should own %doc %{gem_docdir} instead of the ri and rdoc directories, since the %{gem_docdir} represents the root of the gem documentation (see [1, 2]). * Use macros where possible - Please replace %{gem_instdir}/lib with %{gem_libdir} * .yard-doc - There is no such folder in the gem. Please drop the .yard-doc line from the %files section, since the package builds just fine without it in mock or koji. * Missing requires - There must be specified runtime dependency on RubyGems, since rubygems package owns the directory structure, where the gem is installed, i.e.: Requires: rubygems - There are missing other runtime dependencies. The gem specifies dependency on actionpack ~> 3.0 and activemodel ~> 3.0. Please fix the dependencies. * Invalid characters - Please drop the sed line replacing the UTF charactes and instead use: LANG=en_US.utf8 gem build %{gem_name}.gemspec * Test suite - There are only 4 failing tests due to missing country_select gem, so it is worth of enabling the test suite. Please place following lines into appropriate places of your .spec file to do so: BuildRequires: rubygem(mocha) BuildRequires: rubygem(minitest) BuildRequires: rubygem(railties) BuildRequires: rubygem(tzinfo) # Get rid of Bundler. sed -i "/require 'bundler\/setup'/d" test/test_helper.rb # These needs rubygem-country_select which is not packaged for Fedora # so commenting it out sed -i "/require 'country_select'/d" test/test_helper.rb sed -i '104,107 s|^|#|' test/form_builder/general_test.rb sed -i '5,17 s|^|#|' test/inputs/priority_input_test.rb sed -i '38,42 s|^|#|' test/inputs/priority_input_test.rb find ./test -name *_test.rb | xargs testrb -Itest * rpmlint complains rubygem-simple_form-doc.noarch: E: backup-file-in-package /usr/share/gems /gems/simple_form-2.0.2/test/form_builder/general_test.rb.orig - Since this file is coming from the .gem file, you should probably query upstream for a fix [1] https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership [2] https://fedoraproject.org/wiki/Packaging:Ruby#Macros -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review