https://bugzilla.redhat.com/show_bug.cgi?id=839649 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmorsi@xxxxxxxxxx --- Comment #5 from Mo Morsi <mmorsi@xxxxxxxxxx> --- Couple post review-nits * the spec file should be named rubygem-rails_best_practices * can you run the spec suite in a check section in the specfile? * please move the spec suite into the docs subpackage * please rm the files you exclude earlier in the spec and remove those excludes from the files section * slim is listed as a dev dependency on rubygems.org but is not referenced in this spec, is it needed? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review