https://bugzilla.redhat.com/show_bug.cgi?id=858060 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx --- Comment #9 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Hi Ernie, a few points: 1) You're using the older systemd scriptlets here. That's fine for Fedora 17 or older, but just be sure to use the newer macroized scriptlets for Fedora 18+ targets (https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd). You can either conditionalize this in the spec, or you can make the change in the F18 and "master" branches in git. 2) You also do not need to define a BuildRoot, delete the BuildRoot in %install, or define a default %clean section, unless you're building for EPEL (which I happen to know from talking to Darryl that you are), so just be aware of that for any future Fedora only packages. 3) You have several config files in this package, I assume they are being used as opposed to being included solely for reference. If they are being used, please mark them as %config(noreplace) in %files: %config(noreplace) %{_datadir}/snmp/qpid010.conf This ensures that these config files are not replaced when this package is upgraded. ****** Clarify these items for me, and I'll go ahead and finish off this review. Sorry for the delay! :) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review