https://bugzilla.redhat.com/show_bug.cgi?id=800284 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- AtomicParsley.spec.old 2012-05-09 07:36:25.372000202 +0000 +++ AtomicParsley.spec 2012-09-26 18:50:26.000000000 +0000 @@ -1,31 +1,37 @@ -Summary: Command-Line Program to Read and Set iTunes-style Metadata Tags +Summary: Command-line program to read and set MPEG-4 tags and metadata compatible with iPod/iTunes URL: http://atomicparsley.sourceforge.net Name: AtomicParsley Version: 0.9.0 -Release: 9%{?dist} -License: GPLv2 +Release: 10%{?dist} +License: GPLv2+ Group: Applications/Multimedia -#Source0: http://prdownloads.sourceforge.net/atomicparsley/%{name}-source-%{version}.zip Source0: http://downloads.sourceforge.net/project/atomicparsley/atomicparsley/%{name}%20v%{version}/%{name}-source-%{version}.zip -#Source1: http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Patch0: %{name}-fix_bad_math.patch #BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot %description -Command line program that can read and set iTunes-style meta data -tags in MPEG-4 files (M4V, M4A, MP4, MOV) & 3gp assets in 3GPP/3GPP2 files. +AtomicParsley is a command line program for reading, parsing and setting +tags and metadata into MPEG-4 files supporting these styles of metadata: + +. iTunes-style metadata into .mp4, .m4a, .m4p, .m4v, .m4b files +. 3gp-style assets (3GPP TS 26.444 version 6.4.0 Release 6 specification + conforming) in 3GPP, 3GPP2, MobileMP4 & derivatives +. ISO copyright notices at movie & track level for MPEG-4 & derivative files +. uuid private user extension text & file embedding for MPEG-4 & derivative files + %prep +# This 'rm' must be *before* %setup because the __MACOSX directory is outside the +# main source directory, so a %clean will not actually clean it. rm -rf __MACOSX %setup -q -n "%{name}-source-%{version}" -#cp %{S:1} COPYING %patch0 -%__sed -i 's/-O2/$OPTFLAGS/g;' build - -%__sed -i '1aset -e' build +sed -i 's/-O2/$OPTFLAGS/g;' build +sed -i 's/g++/$CXX/g;' build +sed -i '1aset -e' build %build CXX="%__cxx" \ @@ -33,23 +39,22 @@ ./build %install -%__install -D -s -m0755 AtomicParsley "%{buildroot}%{_bindir}/AtomicParsley" +install -D -s -m0755 AtomicParsley "%{buildroot}%{_bindir}/AtomicParsley" -#%clean -#rm -rf "%{buildroot}" - %files -#%defattr(-,root,root) %doc COPYING AP\ buglist.txt Using\ AtomicParsley.rtf %{_bindir}/AtomicParsley %changelog -* Fri Mar 02 2012 Avi Alkalay <avi@xxxxxxx> 0.9.0-9.fc16 +* Tue Sep 25 2012 Avi Alkalay <avi@xxxxxxx> 0.9.0-10 +- Editing with comments from https://bugzilla.redhat.com/show_bug.cgi?id=800284#c3 + +* Fri Mar 02 2012 Avi Alkalay <avi@xxxxxxx> 0.9.0-9 - Editing with comments from https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190#c1 -* Wed Feb 22 2012 Avi Alkalay <avi@xxxxxxx> 0.9.0-7.fc16 +* Wed Feb 22 2012 Avi Alkalay <avi@xxxxxxx> 0.9.0-7 - RPM and patches adapted and built for Fedora 16 based on Madriva SRPM * Thu Jul 22 2010 pascal@xxxxxxxxxxxxxx > TODO: The summary emphasis a service, but the tool manipulates MPEG-4 atoms regardless > of the origin of a file. Please change the summary to be more descriptive (e.g. > `Manipulate MPEG-4 metadata'). -Summary: Command-Line Program to Read and Set iTunes-style Metadata Tags +Summary: Command-line program to read and set MPEG-4 tags and metadata compatible with iPod/iTunes Ok. > TODO: The same applies to the description. Copying first paragraph with the list of > metadata profiles from project web page sounds better for me. %description -Command line program that can read and set iTunes-style meta data -tags in MPEG-4 files (M4V, M4A, MP4, MOV) & 3gp assets in 3GPP/3GPP2 files. +AtomicParsley is a command line program for reading, parsing and setting +tags and metadata into MPEG-4 files supporting these styles of metadata: + +. iTunes-style metadata into .mp4, .m4a, .m4p, .m4v, .m4b files +. 3gp-style assets (3GPP TS 26.444 version 6.4.0 Release 6 specification + conforming) in 3GPP, 3GPP2, MobileMP4 & derivatives +. ISO copyright notices at movie & track level for MPEG-4 & derivative files +. uuid private user extension text & file embedding for MPEG-4 & derivative files + Ok. > FIX: All files are distributed under GPLv2 or later version. Change the License tag to > GPLv2+. -License: GPLv2 +Release: 10%{?dist} +License: GPLv2+ Ok. > TODO: Remove the useless commented code from SPEC file (Source1, etc.). It's better now. TODO: Remove #BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot. > TODO: Append a slash to the URL to provide normalized URL. Not addressed. > TODO: The `rm -rf __MACOSX' command in %prep section should go after %setup. %prep +# This 'rm' must be *before* %setup because the __MACOSX directory is outside the +# main source directory, so a %clean will not actually clean it. I still can't understand how removing directory before unpacking sources can remove the directory delivered with sources. TODO: If the directory is created in %build or %install section, you should remove it there. Or better fix the build script. > TODO: Replace %__sed with plain `sed'. > TODI: Replace %__install with plain `install'. -%__sed -i 's/-O2/$OPTFLAGS/g;' build - -%__sed -i '1aset -e' build +sed -i 's/-O2/$OPTFLAGS/g;' build +sed -i 's/g++/$CXX/g;' build +sed -i '1aset -e' build Ok. > TODO: Setting CXX variable is useless. It's not used anywhere in the build script. > Maybe you want to replace `g++' with `$CXX' in the build script. Ok. $ rpmlint AtomicParsley.spec ../SRPMS/AtomicParsley-0.9.0-10.fc19.src.rpm ../RPMS/x86_64/AtomicParsley-*0.9.0-10.* AtomicParsley.spec:11: W: macro-in-comment %{_tmppath} AtomicParsley.spec:11: W: macro-in-comment %{name} AtomicParsley.spec:11: W: macro-in-comment %{version} AtomicParsley.spec:11: W: macro-in-comment %{release} AtomicParsley.spec:26: W: macro-in-comment %setup AtomicParsley.spec:27: W: macro-in-comment %clean AtomicParsley.spec:11: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 11) AtomicParsley.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal AtomicParsley.src: E: summary-too-long C Command-line program to read and set MPEG-4 tags and metadata compatible with iPod/iTunes AtomicParsley.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal AtomicParsley.src: W: spelling-error %description -l en_US uuid -> quid AtomicParsley.src: E: description-line-too-long C . uuid private user extension text & file embedding for MPEG-4 & derivative files AtomicParsley.src:11: W: macro-in-comment %{_tmppath} AtomicParsley.src:11: W: macro-in-comment %{name} AtomicParsley.src:11: W: macro-in-comment %{version} AtomicParsley.src:11: W: macro-in-comment %{release} AtomicParsley.src:26: W: macro-in-comment %setup AtomicParsley.src:27: W: macro-in-comment %clean AtomicParsley.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 11) AtomicParsley.x86_64: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal AtomicParsley.x86_64: E: summary-too-long C Command-line program to read and set MPEG-4 tags and metadata compatible with iPod/iTunes AtomicParsley.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal AtomicParsley.x86_64: W: spelling-error %description -l en_US uuid -> quid AtomicParsley.x86_64: E: description-line-too-long C . uuid private user extension text & file embedding for MPEG-4 & derivative files AtomicParsley.x86_64: E: incorrect-fsf-address /usr/share/doc/AtomicParsley-0.9.0/COPYING AtomicParsley.x86_64: W: no-manual-page-for-binary AtomicParsley AtomicParsley-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 1 specfiles checked; 6 errors, 21 warnings. TODO: Expand tabulators to spaces (you can use `expand -t4' command). TODO: Shorten summary text. E.g. by removing the iTunes words. TODO: Wrap description text to 80 columns. TODO: Replace the ASCII stop `bullets' with better approximation. E.g. an asterisk. > FIX: Remove the dead code from spec file, or escape percent characters with another > percent. The SPEC macros are evaluated even inside shell comments FIX: Remove commented BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot. FIX: The debug file is empty because you install the binary with `-s' option. Don't do that. > FIX: Remove the `.fc16' from changelog entries. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4546320). Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review