Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-lirc - Linux Infrared Remote Control python module https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228296 ------- Additional Comments From ville.skytta@xxxxxx 2007-02-13 16:24 EST ------- Adding the extra docs is a nice idea, however they currently suffer from genericish SourceX file names. Prefix them by %{name}-* (in SRPM, not when installed)? About licensing, LGPL section 3 says: "You may opt to apply the terms of the ordinary GNU General Public License instead of this License to a given copy of the Library. To do this, you must alter all the notices that refer to this License, so that they refer to the ordinary GNU General Public License, version 2, instead of to this License." I'm not 100% sure what that means in practical terms, but it sounds to me as if the license info should be changed not only in the License tag, but also the C source file as well as PKG-INFO, and possibly the newly added changes. Or at least add a note somewhere prominent about the change (separate file installed as %doc or something). What do you think? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review