Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: SysVinit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226475 ------- Additional Comments From notting@xxxxxxxxxx 2007-02-13 15:53 EST ------- (In reply to comment #2) > Issues: > > 1. Ok, I have to ask... why does this package use StUdLyCaps? > The upstream package is called 'sysvinit'. I know it's been that way > forever, but perhaps we could fix that now? History. I suppose we could change it. Would need the usual obsoletes/provides stuff. > 2. Might include the LICENSE file, which is not the GPL, but at least explains > that this package is released under the GPL and where to get it. > I suppose you could also bug upstream about including a copy. Done. > 3. Use the approved buildroot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Yeah, was already fixed in CVS. Should have built that. > 4. There is a single include file shipped here in the main package: > > /usr/include/initreq.h > > It seems useless to make a -devel package for one header, but does it make > any sense to ship it at all? Perhaps that should just get dropped? See bug 119039; it's just a structure definition. > 5. Our pal rpmlint says: > a) > W: SysVinit summary-ended-with-dot Programs which control basic system processes. > b) > W: SysVinit no-url-tag Fixed. > e) > W: SysVinit dangerous-command-in-%post ln > > Suggest: Don't see an easy way to avoid the ln. Do you? Taken out and shot. initrunlvl hasn't been supported by init for nearly 4 years. Oops. > 6. Upstream seems not very active (last release 2004), but would it still > be worth trying to push some of these patches upstream? There are a lot of > them here... Most everything has been sent at one point or another. > 7. Minor: Might replace the /usr/bin in %files with %{_bindir} Would have to patch the makefiles. > 8. Minor: add dist tag? Well, we never rebase/update it, so, not sure what it gains. New stuff uploaded at http://people.redhat.com/notting/review/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review