[Bug 759823] Review Request: libkdtree++ - C++ template container implementation of kd-tree sorting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=759823

--- Comment #10 from Eric Smith <eric@xxxxxxxxxxxx> ---
Thanks for reviewing this. I really appreciate the recommendations as to how to
fix the problems. I've taken most but not all of the advice, as further
explained below. Here are the updated files:

Spec URL: http://fedorapeople.org/~brouhaha/libkdtree++/libkdtree++.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/libkdtree++/libkdtree++-0.7.0-3.fc17.src.rpm

I don't intend to support EL5 unless someone requests it, so for now I'm not
adding the requires for pkgconfig.

If examples depends on devel, rpmlint gives the errors "E: devel-dependency"
and "E: explicit-lib-dependency libkdtree++-devel". While these conditions are
basically self-explanatory, it's not obvious to me why they are considered to
be errors, and I don't see an explanation of them on the "Common rpmlint
issues" wiki page.

I'm not convinced about installing kdtree.py with 755 permissions, as it isn't
intended to be executed directly. If it's 755, rpmlint gives the error "E:
script-without-shebang". All of the other .py files in my
/usr/lib/python2.7/site-packages directory (from various other Fedora RPM
files) are 644, and only of of them has a shebang.  The RPMs providing these
.py files with 644 perms are:

abrt-addon-python-2.0.13-1.fc17.x86_64
dbus-python-0.83.0-9.fc17.x86_64
python-decorator-3.3.3-1.fc17.noarch
python-setuptools-0.6.27-2.fc17.noarch
python-GnuPGInterface-0.3.2-9.fc17.noarch
sssd-1.8.4-14.fc17.x86_64
python-IPy-0.75-2.fc17.noarch
python-magic-5.11-2.fc17.x86_64
python-setuptools-0.6.27-2.fc17.noarch
sssd-1.8.4-14.fc17.x86_64

Also, installing it with 755 does not seem to eliminate the
unstripped-binary-or-object warning, even with a "%filter_provides_in
%{python_sitearch}/.*\.so$", and I still get an empty-debuginfo-package unless
I keep the macro to disable automatic debuginfo processing.

I'm unclear on whether the Python packaging standard requires 755 in a case
like this, but given that the actual practice is clearly to use 644, for now
I'm keeping 644.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]