https://bugzilla.redhat.com/show_bug.cgi?id=832635 --- Comment #14 from Truong Anh Tuan <tuanta@xxxxxxxxxxxxxxx> --- (In reply to comment #13) All issues have been addressed. Upstream developers have updated the sources and released as the new one 2.0.1. The new .spec file: http://tuanta.fedorapeople.org/pencil/pencil.spec The new .src file: http://tuanta.fedorapeople.org/pencil/pencil-2.0.1-1.fc17.src.rpm Please review them for me. Thanks. See some other comments below. > [!]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > [!]: MUST License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. No licenses > found. Please check the source files for licenses manually. This has been fixed. > [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: Clean is needed only if supporting EPEL5 Updated. > [!]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Has been fixed. Keep only one license file (COPYING in root folder) > Rpmlint > ------- > Checking: pencil-2.0-2.fc19.src.rpm > pencil-2.0-2.fc19.noarch.rpm > pencil.src: W: invalid-url Source0: > http://evoluspencil.googlecode.com/files/pencil-2.0.tar.gz HTTP Error 404: > Not Found I think it's normal with source in Google code. You can try to download directly: http://evoluspencil.googlecode.com/files/pencil-2.0.1.tar.gz > pencil.noarch: W: no-manual-page-for-binary pencil There is no manual page in upstream source (it may be not necessary). Is it ok? > Issues: > > - please clarify with upstream, which license is is the one to use, ask > upstream to delete the other > - there are several files from windows included. please delete them: > /usr/share/pencil/chrome/icons/default/main-window.ico > /usr/share/pencil/chrome/icons/default/pencilMainWindow.ico > /usr/share/pencil/icons/default/main-window.ico > /usr/share/pencil/skin/classic/images/pencil.ico > /usr/share/pencil/skin/classic/pencil.ico Those files have been removed. > - what are those files for: > /usr/share/pencil/platform/WINNT > /usr/share/pencil/platform/WINNT/chrome.manifest Removed. > - settings: path to external bitmap editor: is that correctable? currently, > it points to /usr/local/bin/gimp-2.7 which is clearly wrong for several > reasons. Updated. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review