https://bugzilla.redhat.com/show_bug.cgi?id=853514 Guillermo Gómez <guillermo.gomez@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> --- Unneeded macros... %global gem_dir /usr/share/rubygems %global gem_instdir %{gem_dir}/gems/%{gem_name}-%{version} %global gem_docdir %{gem_dir}/doc/%{gem_name}-%{version} %global gem_libdir %{gem_instdir}/lib All of them are provided by rubygems-devel. Source0: http://rubygems.org/downloads/clouddb-0.0.1.gem Please use macros for name and version, sample: Source0: http://rubygems.org/downloads/%{gem_name}-%{version}.gem The rest looks good to me :) Please fix to go a second round. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review