https://bugzilla.redhat.com/show_bug.cgi?id=860515 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On|853692 | |(mate-settings-daemon) | --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok sources: ok 7fda787ad446c43f13baceedcbd8de50 mate-themes-1.4.0.tar.xz 1. SHOULD: include BuildArch: noarch as seems to be all architecture-independent content 2. scriptets: NOT ok MUST: add icon scriplets for each icon theme installed. for example, %post touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ... %postun if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/Fog &> /dev/null || : touch --no-create %{_datadir}/icons/PrintLarge &> /dev/null || : touch --no-create %{_datadir}/icons/Quid &> /dev/null || : ... gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : fi %posttrans gtk-update-icon-cache %{_datadir}/icons/Fog &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/PrintLarge &> /dev/null || : gtk-update-icon-cache %{_datadir}/icons/Quid &> /dev/null || : ... 3. MUST fix BuildRequires. Current BuildRequires is way too much, and missing a couple items, this minimal set seems to work for me: BuildRequires: icon-naming-utils mate-common mate-doc-utils # aka gtk2-engines-devel BuildRequires: pkgconfig(gtk-engines-2) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review