https://bugzilla.redhat.com/show_bug.cgi?id=858380 --- Comment #9 from gil cattaneo <puntogil@xxxxxxxxx> --- hi Clément, [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Patch1 (0001-renamed-library.patch) Source0 (gluegen-v2.0-rc10.tar.7z) Patch3 (0003-disable-executable-tmp- tests.patch) Patch2 (0002-use-fedora-jni.patch) Patches use names, which do not follow the Fedora guidelines. The guidelines require prefixes so that users of "rpmbuild" can easily clean up their SOURCES directory. should be Patch1: %{name}-XYZ.patch or Patch1: %{name}-%{version}-XYZ.patch are really required - usefull? [!]: MUST Header files in -devel subpackage, if present. Note: gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example1/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example2/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example3/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example4/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example5/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example6/function.h gluegen2-doc-2.0-0.3.rc10.fc18.noarch.rpm : /usr/share/doc/gluegen2/example7/function.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages %%global gluegen_devel_dir %{_datadir}/gluegen2-devel you can simply renamed %{_datadir}/gluegen2 ... only if you want thanks regards -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review