https://bugzilla.redhat.com/show_bug.cgi?id=832698 --- Comment #3 from Karel Klíč <kklic@xxxxxxxxxx> --- I found a couple of minor issues. Fixing them would make the package better. 1. The spec file should not include the %clean section with "rm -rf %{buildroot}". 2. There should be no "rm -rf %{buildroot}" at the beginning of the %install section. 3. "%defattr(-,root,root,-)" should not be included at the beginning of the %files section. 4. Rpmlint warnings should be fixed rpmlint exploitable-1.01-1.fc19.noarch.rpm exploitable.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/exploitable-1.01/README.txt exploitable.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/exploitable-1.01/AUTHORS.txt 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Perhaps the following link helps? http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings 5. AUTHORS.txt and README.txt from /usr/share/triage-tools should be installed in %doc (/usr/share/doc/exploitable-1.01/). 6. LICENSE.txt should be included in %doc files. I have also tested the package on RHEL-6. The GDB command works only after importing it manually: (gdb) exploitable Undefined command: "exploitable". Try "help". (gdb) require command exploitable_gdb (gdb) exploitable Description: Heap error Short description: HeapError (9/21) Hash: 6687658ff11fd9da15c43c9e6f5259bd.6687658ff11fd9da15c43c9e6f5259bd Exploitability Classification: EXPLOITABLE ... The cert-triage command line tool doesn't work as it cannot find the "exploitable" GDB command: $ cert-triage ./testBranchAv.test Undefined command: "exploitable". Try "help". /usr/bin/cert-triage:152: UserWarning: triage failed ([Errno 2] No such file or directory: '/tmp/triage.pkl'), call=gdb --batch -ex "source exploitable/exploitable-gdb.py" -ex run -ex "exploitable -p /tmp/triage.pkl" --args ./testBranchAv.test warnings.warn("triage failed (%s), call=%s" % (e, call)) Failed to triage (no crash?): ./testBranchAv.test Are you going to include the package in EPEL6? If it is not so, I can test it later today on my Fedora 17 machine at home. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review