https://bugzilla.redhat.com/show_bug.cgi?id=860249 --- Comment #11 from Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> --- (In reply to comment #10) > i was not aware of the dupe when i started. i will not take offence on the > tone in your reply. ?? There would have been no reason to. > the fixed the spec url (it does only differ in the package name anyway): > http://www.math.hu-berlin.de/~florek/adobe-source-code-pro-fonts.spec Thanks. I compared your spec to the one for adobe source sans pro. The points where they differ don't matter too much (your use of %{fontname} is actually more complete) except for one which I missed first: Unless there's a specific reason, you should package only one format of the font, in this case only otf, see https://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#What_if_my_package_bundles_the_same_font_in_several_different_formats.3F So, please remove the 2 occurrences of \*.ttf and increase the -2 to -3. (It's good you did that during review for -1 to -2 already, but please update the changelog also.) Everything else still looks good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review