https://bugzilla.redhat.com/show_bug.cgi?id=836821 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pbrobinson@gmail. | |com) | --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> --- Sorry about delayed response. 1.8.x had build issues, and I've been away. 1.9.0 now builds so updated. (In reply to comment #1) > The license is GPLv2+, but it is actually dual-licensed: Fedora doesn't use the commercial license option so it's the only relevant license for our use case > The FSF address is outdated and should be replaced. Also let upstream know. I'll fix it when it's fixed upstream (it might be already in 1.9.0) but I'll let them know > If this is a snapshot, the release should be different: > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease No it's not a snapshot. It's the release using their git tag. Theit github generated archives have issues so we generate them from the git source but it's still a tagged release so we can still use the standard NVRs > The version number in the changelog also doesn't match. Fixed. > Please add ?_isa, see > http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Added > Why do you require systemd-devel? Because that's where the udev library headers are now and it uses udev. > rpmlint complains about mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > line 1) and the non-american spelling of "utilizing". cec-config should be > in the main package. Line 1 is a comment so it's completely irrelevant. I've updated the comment further. cec-config IS in the main package: $ rpm -qlp libcec-1.9.0-1.fc17.x86_64.rpm /usr/bin/cec-client /usr/bin/cec-config /usr/lib64/libcec.so.1 /usr/lib64/libcec.so.1.0.9 > defattr is no longer necessary. Consider to add ChangeLog as documentation. I thought I had done both of those. Fixed. SPEC: as above SRPM: http://pbrobinson.fedorapeople.org/libcec-1.9.0-1.fc17.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4529045 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review