https://bugzilla.redhat.com/show_bug.cgi?id=853692 --- Comment #15 from Dan Mashal <dan.mashal@xxxxxxxxx> --- >5. MUST remove >export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/ >but I won't consider it a blocker here, but please do remove prior to doing any >official builds Builds fail without this. Please check it. >6. SHOULD remove >%pre >/sbin/ldconfig >this scriptlet is only required in %post and %postun Done >7. SHOULD add >Requires: mate-icon-theme >for /usr/share/icons/mate parent dir ownership (or can you think of some place >lower in the stack to add this dependency?) Done, no I can't. >8. SHOULD remove rpath hacks >chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so >chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer >they're not needed Done but rpmlint still complains. >9. MUST own >%{_libdir}/mate-settings-daemon-1.4.0/ >I'd suggest simplifying the %files list to just ^^ , and not list each item >under it individually. Done. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review