https://bugzilla.redhat.com/show_bug.cgi?id=846481 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- I'll respond to items marked "!" 1. licensing. unsure what the problem is here find -name \*.cpp | xargs licensecheck | grep -v GPL ./qtsingleapplication/qtlockedfile.cpp: UNKNOWN ./qtsingleapplication/qtlocalpeer.cpp: UNKNOWN ./qtsingleapplication/qtlockedfile_win.cpp: UNKNOWN ./qtsingleapplication/qtsingleapplication.cpp: UNKNOWN ./qtsingleapplication/qtlockedfile_unix.cpp: UNKNOWN ./qtsingleapplication/qtsinglecoreapplication.cpp: UNKNOWN ./replaygain/ffmpeginput.cpp: UNKNOWN ./replaygain/mpg123input.cpp: UNKNOWN ./widgets/fancytabwidget.cpp: UNKNOWN ./libmaia/maiaObject.cpp: BSD (2 clause) ./libmaia/maiaXmlRpcServerConnection.cpp: BSD (2 clause) ./libmaia/maiaFault.cpp: BSD (2 clause) ./libmaia/maiaXmlRpcClient.cpp: BSD (2 clause) ./libmaia/maiaXmlRpcServer.cpp: BSD (2 clause) looks like found another bundled lib, qtsingleapplication. anyway, eplaygain/libebur128-COPYING is basically BSD and ./widgets/fancytabwidget.cpp is LGPLv2 2. MUST %build honors applicable compiler flags or justifies otherwise. The compilation is not verbose, you can export the VERBOSE=1 or pass it to the build is verbose (cmake is verbose by default in fedora). not sure what you mean here either. 3. [!]: MUST Sources contain only permissible code or content. same issue as licence contant, but you must remove file relative to ffmpeg build. I found nothing that had license issues, nor is the ffmpeg-interfacing code have problems with patents as far as I can tell. can you elaborate? 4. [!]: MUST License field in the package spec file matches the actual license. The combined work, of GPLv2+ and BSD and LGPLv2 is indeed License: GPLv2+ Outstanding item: bundled libraries qtsingleapplication and limaia. the former is in fedora, the latter seems to be a fairly old library, designed to be bundled (to buildsystem support to be installed system wide) and has no formal releases as far as I can tell. :( I may well just build a separate libmaia from within cantata for now. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review