https://bugzilla.redhat.com/show_bug.cgi?id=853692 --- Comment #9 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- sources: ok $ md5sum *.xz 5d7608bf8b80f4847e6b146379568b83 mate-settings-daemon-1.4.0.tar.xz 5. MUST remove export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/ but I won't consider it a blocker here, but please do remove prior to doing any official builds 6. SHOULD remove %pre /sbin/ldconfig this scriptlet is only required in %post and %postun 7. SHOULD add Requires: mate-icon-theme for /usr/share/icons/mate parent dir ownership (or can you think of some place lower in the stack to add this dependency?) 8. SHOULD remove rpath hacks chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer they're not needed 9. MUST own %{_libdir}/mate-settings-daemon-1.4.0/ I'd suggest simplifying the %files list to just ^^ , and not list each item under it individually. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review