https://bugzilla.redhat.com/show_bug.cgi?id=858105 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Review: [+] OK [-] NA [?] Issue [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [?] Meets Packaging Guidelines. ^^ The files that you're putting in %sysconfig: Shouldn't they be using the %config(noreplace) macro etc? Guideline here: http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files Also, since you're owning everything under sysconfdir/ros, won't the file you've ghosted get owned too? I'm not sure how the two macros intersect. Mock says: DEBUG: warning: File listed twice: /etc/ros/rosdep/sources.list.d/20-default.list Please make changes similar to python-rospkg: - Build in build section - Only install in install section - Cosmetic changes to make the file section clearer would be nice too :) [+] License [+] License field in spec matches [?] License file included in package ^^ Please file a bug upstream requesting them to ship a licence file. Not a blocker [+] Spec in American English [+] Spec is legible. [-] Sources match upstream md5sum: Github checkout: NA [+] Package is code or permissible content. [-] Packages %doc files don't affect runtime. Nothing in %doc [+] Package compiles and builds on at least one arch. Built in mock for rawhide x86_64 [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [+] No rpmlint output. ^^ Nothing worrisome [ankur@ankur SRPMS]$ rpmlint ./python-rosdep-0.9.7-1.20120917git5e1ecef.fc17.src.rpm ../SPECS/python-rosdep.spec /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm python-rosdep.src: W: invalid-url Source0: ros-rosdep-0.9.5-11-g5e1ecef.tar.gz ../SPECS/python-rosdep.spec: W: invalid-url Source0: ros-rosdep-0.9.5-11-g5e1ecef.tar.gz python-rosdep.noarch: W: no-manual-page-for-binary rosdep-gbp-brew python-rosdep.noarch: W: no-manual-page-for-binary rosdep-source python-rosdep.src: W: invalid-url Source0: ros-rosdep-0.9.5-11-g5e1ecef.tar.gz 3 packages and 1 specfiles checked; 0 errors, 5 warnings. [ankur@ankur SRPMS]$ [-] final provides and requires are sane: [ankur@ankur result]$ review-req-check == python-rosdep-0.9.7-1.20120917git5e1ecef.fc19.noarch.rpm == Provides: python-rosdep = 0.9.7-1.20120917git5e1ecef.fc19 Requires: /usr/bin/python python(abi) = 2.7 == python-rosdep-0.9.7-1.20120917git5e1ecef.fc19.src.rpm == Provides: Requires: python-devel python-setuptools-devel python-sphinx SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [-] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [-] check for outstanding bugs on package. (For core merge reviews) Issues: 1. Please make the cosmetic changes 2. Please check if the %config(noreplace) macro needs to be used 3. Please check the play between the ghost and dir ownership. Looks okay, since rpmlint didn't say anything either. Do confirm though. Small issues. Nothing major. Please make the changes and the package is ready to go! Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review