[Bug 718317] Review Request: asforza4 - 4-in-a-row in a dockapp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=718317

--- Comment #10 from Matthias Runge <mrunge@xxxxxxxxxx> ---
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[!]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.


==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[!]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[!]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)" For detailed output of
     licensecheck see file:
     /home/mrunge/review/718317-asforza4/licensecheck.txt
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL5 is required
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[-]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Rpmlint
-------
Checking: asforza4-debuginfo-2.10-4.fc19.x86_64.rpm
          asforza4-2.10-4.fc19.src.rpm
          asforza4-2.10-4.fc19.x86_64.rpm
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/asforza4.h
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/net/net.c
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/asforza4.c
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/net/net.h
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/wmgeneral/misc.c
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/guile_ext/asf4_ext_lib.h
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/asforza4/guile_ext/asf4_ext_lib.c
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/wmgeneral/list.c
asforza4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/asforza4-2.10/wmgeneral/list.h
asforza4.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app,
paddock
asforza4.src: I: enchant-dictionary-not-found de
asforza4.src: W: spelling-error %description -l en_US dockable -> lockable,
dock able, dock-able
asforza4.src: W: spelling-error %description -l en_US dockapps -> dock apps,
dock-apps, paddocks
asforza4.src: W: spelling-error %description -l en_US Forza -> Fora
asforza4.src: W: spelling-error %description -l en_US italian -> Italian
asforza4.src:43: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 43)
asforza4.x86_64: W: spelling-error Summary(en_US) dockapp -> dock app,
dock-app, paddock
asforza4.x86_64: W: spelling-error %description -l en_US dockable -> lockable,
dock able, dock-able
asforza4.x86_64: W: spelling-error %description -l en_US dockapps -> dock apps,
dock-apps, paddocks
asforza4.x86_64: W: spelling-error %description -l en_US Forza -> Fora
asforza4.x86_64: W: spelling-error %description -l en_US italian -> Italian
asforza4.x86_64: E: statically-linked-binary /usr/bin/forza44as
asforza4.x86_64: W: only-non-binary-in-usr-lib
asforza4.x86_64: E: incorrect-fsf-address
/usr/share/asforza4/asf4_guile_ext/asf4_ext_lib.scm
asforza4.x86_64: E: incorrect-fsf-address
/usr/lib64/asforza4/asf4_plugin/asf4_mailchk.scm
asforza4.x86_64: E: incorrect-fsf-address
/usr/share/asforza4/asf4_guile_ext/asf4e_char_map.scm
asforza4.x86_64: E: incorrect-fsf-address /usr/share/doc/asforza4-2.10/COPYING
asforza4.x86_64: E: incorrect-fsf-address
/usr/lib64/asforza4/asf4_plugin/asf4_pppmon.scm
asforza4.x86_64: W: no-manual-page-for-binary forza44as
asforza4.x86_64: W: no-manual-page-for-binary asforza4
3 packages and 0 specfiles checked; 15 errors, 14 warnings.


Rpmlint (installed packages)
----------------------------
# rpmlint asforza4
asforza4.x86_64: W: spelling-error Summary(en_US) dockapp -> dock app,
dock-app, paddock
asforza4.x86_64: I: enchant-dictionary-not-found de
asforza4.x86_64: W: spelling-error %description -l en_US dockable -> lockable,
dock able, dock-able
asforza4.x86_64: W: spelling-error %description -l en_US dockapps -> dock apps,
dock-apps, paddocks
asforza4.x86_64: W: spelling-error %description -l en_US Forza -> Fora
asforza4.x86_64: W: spelling-error %description -l en_US italian -> Italian
asforza4.x86_64: W: ldd-failed /usr/bin/forza44as
asforza4.x86_64: E: statically-linked-binary /usr/bin/forza44as
asforza4.x86_64: W: only-non-binary-in-usr-lib
asforza4.x86_64: E: incorrect-fsf-address
/usr/share/asforza4/asf4_guile_ext/asf4_ext_lib.scm
asforza4.x86_64: E: incorrect-fsf-address
/usr/lib64/asforza4/asf4_plugin/asf4_mailchk.scm
asforza4.x86_64: E: incorrect-fsf-address
/usr/share/asforza4/asf4_guile_ext/asf4e_char_map.scm
asforza4.x86_64: E: incorrect-fsf-address /usr/share/doc/asforza4-2.10/COPYING
asforza4.x86_64: E: incorrect-fsf-address
/usr/lib64/asforza4/asf4_plugin/asf4_pppmon.scm
asforza4.x86_64: W: no-manual-page-for-binary forza44as
asforza4.x86_64: W: no-manual-page-for-binary asforza4
1 packages and 0 specfiles checked; 6 errors, 9 warnings.
# echo 'rpmlint-done:'

Requires
--------
asforza4-debuginfo-2.10-4.fc19.x86_64.rpm (rpmlib, GLIBC filtered):


asforza4-2.10-4.fc19.x86_64.rpm (rpmlib, GLIBC filtered):

    libX11.so.6()(64bit)  
    libXext.so.6()(64bit)  
    libXpm.so.4()(64bit)  
    libc.so.6()(64bit)  
    libdl.so.2()(64bit)  
    libguile.so.17()(64bit)  
    libpthread.so.0()(64bit)  
    rtld(GNU_HASH)  
    xorg-x11-fonts-misc  

Provides
--------
asforza4-debuginfo-2.10-4.fc19.x86_64.rpm:

    asforza4-debuginfo = 2.10-4.fc19
    asforza4-debuginfo(x86-64) = 2.10-4.fc19

asforza4-2.10-4.fc19.x86_64.rpm:

    asforza4 = 2.10-4.fc19
    asforza4(x86-64) = 2.10-4.fc19

MD5-sum check
-------------
http://downloads.sourceforge.net/asforza4/asforza4-2.10.tar.gz :
  CHECKSUM(SHA256) this package     :
819ae192ee34977869e4a938d31478dec06bc48138ec6b1a819a3aaad7ab9165
  CHECKSUM(SHA256) upstream package :
819ae192ee34977869e4a938d31478dec06bc48138ec6b1a819a3aaad7ab9165


Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09
Command line :/usr/bin/fedora-review -b 718317



Oh well,
currently found so far:
- cd-misc is bundled (in asf4_cdp-1.0)
- libcdplay in asf4_cdp-1-0 comes from libcdplay, which was also forked by
another person, and then used here
- wmgeneral looks like copied from WindowMaker, a version dated in 1993/1997;
do you really want to support this old stuff?

[mrunge@turing results]$ rpm -qlp asforza4-2.10-4.fc19.x86_64.rpm 
/usr/bin/asforza4
/usr/bin/forza44as
/usr/lib64/asforza4
/usr/lib64/asforza4/asf4_plugin
/usr/lib64/asforza4/asf4_plugin/asf4_mailchk.scm
/usr/lib64/asforza4/asf4_plugin/asf4_pppmon.scm
/usr/share/asforza4
/usr/share/asforza4/asf4_guile_ext
/usr/share/asforza4/asf4_guile_ext/asf4_ext_lib.scm
/usr/share/asforza4/asf4_guile_ext/asf4e_char_map.scm
/usr/share/asforza4/asf4_guile_ext/asf4e_string_lib.scm
/usr/share/asforza4/asf4_themes
/usr/share/asforza4/asf4_themes/asf4_CtrlZbg.xpm
/usr/share/asforza4/asf4_themes/asf4_asf4.xpm
/usr/share/asforza4/asf4_themes/asf4_blackbox.xpm
/usr/share/asforza4/asf4_themes/asf4_default.xpm
/usr/share/asforza4/asf4_themes/asf4_duke.xpm
/usr/share/asforza4/asf4_themes/asf4_linux.xpm
/usr/share/asforza4/asf4_themes/asf4_sexy1.xpm
/usr/share/doc/asforza4-2.10
/usr/share/doc/asforza4-2.10/COPYING
/usr/share/doc/asforza4-2.10/ChangeLog
/usr/share/doc/asforza4-2.10/README

OK, it looks like you didn't copy that stuff into the rpm. I'd remove that
bundled stuff totally in %prep section


You must get rid of forza44as:
[mrunge@turing asforza4]$ ldd forza44as
    not a dynamic executable
forza44as: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically
linked, for GNU/Linux 2.4.0,
BuildID[sha1]=0x223a1cf33848be10ee008bf3e0469a8312cd103a, stripped

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]