https://bugzilla.redhat.com/show_bug.cgi?id=859675 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Erwin I'm not sponsor This is a informal review Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [ ]: MUST Package does not contain kernel modules. [ ]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [!]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: sed [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [ ]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [ ]: MUST Development files must be in a -devel package [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [ ]: MUST Package complies to the Packaging Guidelines [!]: MUST Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Packager: Erwin Waterlander <waterlan@xxxxxxxxx> [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)" For detailed output of licensecheck see file: /home/makerpm/859675-wcd/licensecheck.txt [ ]: MUST The spec file handles locales properly. [ ]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [ ]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [ ]: MUST Package is not relocatable. [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [ ]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: sed See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [!]: MUST Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Packager: Erwin Waterlander <waterlan@xxxxxxxxx> See: None Rpmlint ------- Checking: wcd-debuginfo-5.2.2-1.fc17.x86_64.rpm wcd-5.2.2-1.fc17.src.rpm wcd-5.2.2-1.fc17.x86_64.rpm wcd-debuginfo.x86_64: W: invalid-license GPL wcd.src: W: spelling-error Summary(en_US) chdir -> chair, choir wcd.src: W: summary-not-capitalized C chdir for DOS and Unix wcd.src: W: invalid-license GPL wcd.src:9: W: hardcoded-packager-tag Erwin wcd.x86_64: W: spelling-error Summary(en_US) chdir -> chair, choir wcd.x86_64: W: summary-not-capitalized C chdir for DOS and Unix wcd.x86_64: W: incoherent-version-in-changelog 5.2.2 ['5.2.2-1.fc17', '5.2.2-1'] wcd.x86_64: W: invalid-license GPL wcd.x86_64: W: non-conffile-in-etc /etc/profile.d/wcd.csh wcd.x86_64: W: non-conffile-in-etc /etc/profile.d/wcd.sh wcd.x86_64: W: no-manual-page-for-binary wcd.exe 3 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint wcd wcd.x86_64: W: spelling-error Summary(en_US) chdir -> chair, choir wcd.x86_64: W: summary-not-capitalized C chdir for DOS and Unix wcd.x86_64: W: incoherent-version-in-changelog 5.2.2 ['5.2.2-1.fc17', '5.2.2-1'] wcd.x86_64: W: invalid-license GPL wcd.x86_64: W: non-conffile-in-etc /etc/profile.d/wcd.csh wcd.x86_64: W: non-conffile-in-etc /etc/profile.d/wcd.sh wcd.x86_64: W: no-manual-page-for-binary wcd.exe 1 packages and 0 specfiles checked; 0 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- wcd-debuginfo-5.2.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): wcd-5.2.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): libc.so.6()(64bit) libncursesw.so.5()(64bit) libtinfo.so.5()(64bit) libunistring.so.0()(64bit) rtld(GNU_HASH) Provides -------- wcd-debuginfo-5.2.2-1.fc17.x86_64.rpm: wcd-debuginfo = 5.2.2-1.fc17 wcd-debuginfo(x86-64) = 5.2.2-1.fc17 wcd-5.2.2-1.fc17.x86_64.rpm: wcd = 5.2.2-1.fc17 wcd(x86-64) = 5.2.2-1.fc17 MD5-sum check ------------- http://waterlan.home.xs4all.nl/wcd-5.2.2-src.tar.gz : CHECKSUM(SHA256) this package : e6b0a1ad728bde723272db8c93a86b7022823de81a74027b1108049cb22e91f2 CHECKSUM(SHA256) upstream package : e6b0a1ad728bde723272db8c93a86b7022823de81a74027b1108049cb22e91f2 Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09 Command line :/usr/bin/fedora-review -b 859675 External plugins: In the spec remove sed in BuildRequires http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Change the macro $RPM_BUILD_ROOT to %{buildroot} Remove Packager: Erwin Waterlander <waterlan@xxxxxxxxx> In the section Changelog increment the number release whenever you make a change Example 5.2.2-1 Regards -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review