https://bugzilla.redhat.com/show_bug.cgi?id=822718 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- The file links are dead, these are the right ones: Spec URL: http://rebus.fedorapeople.org/SPECS/libesedb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/libesedb-20120102-1.fc17.src.rpm Koji scratch build for f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4513986 Your package is almost fine, some objections though: The initial cleaning of buildroot in %install is an artifact from older Fedora versions (< F10, EPEL5). Please remove the appropriate line. Currently our man pages are gzipped, but this could change in the future, that's why: %{_mandir}/man1/esedbinfo.1.* %{_mandir}/man3/libesedb.3.* $ rpmlint -i -v * libesedb.src: I: checking libesedb.src: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb.src: E: unknown-key (MD5 The package was signed, but with an unknown key. See the rpm --import option for more information. libesedb.src: I: checking-url http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz (timeout 10 seconds) libesedb.src: W: invalid-url Source0: http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. libesedb.i686: I: checking libesedb.i686: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb.i686: W: no-manual-page-for-binary esedbexport Each executable in standard binary directories should have a man page. libesedb.x86_64: I: checking libesedb.x86_64: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb.x86_64: W: no-manual-page-for-binary esedbexport Each executable in standard binary directories should have a man page. libesedb-debuginfo.i686: I: checking libesedb-debuginfo.i686: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb-debuginfo.x86_64: I: checking libesedb-debuginfo.x86_64: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb-devel.i686: I: checking libesedb-devel.i686: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libesedb-devel.x86_64: I: checking libesedb-devel.x86_64: I: checking-url http://sourceforge.net/projects/libesedb/ (timeout 10 seconds) libesedb-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libesedb.spec: I: checking-url http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz (timeout 10 seconds) libesedb.spec: W: invalid-url Source0: http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. 7 packages and 1 specfiles checked; 1 errors, 6 warnings. This project is no longer hosted at SourceForge. The new download location is http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz. Please don't sign your srpms. It is not really needed and produces annoying output of rpmlint. Please fix the issues (project website, source location, buildroot cleaning, man page extension) and your package is ready for a full review. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review