https://bugzilla.redhat.com/show_bug.cgi?id=859586 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #8 from Michael Scherer <misc@xxxxxxxx> --- I was about to also do the review ( in fact, i have it ready to cut and paste ), but I will let Martin take it. However the license tag is false, as there is code under GPLv2+ and code under lgpl. The fact it provides perl modules is wrong, you should filter them from Provides ( since they are not in perl path ). /usr/libexec/gsm-ussd/ is unowned There is missing deps for xussd, and a .desktop file should be added since that's gui. And script-without-shebang should be corrected, for example, by removing the +x bits from the file ( since they are not scripts ). And you should also comment the patch. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review